[{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5038790608","html_url":"https://github.com/aws/bedrock-agentcore-sdk-python/pull/588#issuecomment-5038790608","issue_url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588","id":5038790608,"node_id":"IC_kwDOPIocp88AAAABLFXX0A","user":{"login":"arielnabavian","id":207775339,"node_id":"U_kgDODGJmaw","avatar_url":"https://avatars.githubusercontent.com/u/207775339?v=4","gravatar_id":"","url":"https://api.github.com/users/arielnabavian","html_url":"https://github.com/arielnabavian","followers_url":"https://api.github.com/users/arielnabavian/followers","following_url":"https://api.github.com/users/arielnabavian/following{/other_user}","gists_url":"https://api.github.com/users/arielnabavian/gists{/gist_id}","starred_url":"https://api.github.com/users/arielnabavian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielnabavian/subscriptions","organizations_url":"https://api.github.com/users/arielnabavian/orgs","repos_url":"https://api.github.com/users/arielnabavian/repos","events_url":"https://api.github.com/users/arielnabavian/events{/privacy}","received_events_url":"https://api.github.com/users/arielnabavian/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-07-21T20:35:35Z","updated_at":"2026-07-21T20:35:35Z","body":"Meant to set this as draft, doing some work to validate parity, ignore for now.","author_association":"NONE","reactions":{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5038790608/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null,"minimized":null},{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5049534492","html_url":"https://github.com/aws/bedrock-agentcore-sdk-python/pull/588#issuecomment-5049534492","issue_url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588","id":5049534492,"node_id":"IC_kwDOPIocp88AAAABLPnIHA","user":{"login":"arielnabavian","id":207775339,"node_id":"U_kgDODGJmaw","avatar_url":"https://avatars.githubusercontent.com/u/207775339?v=4","gravatar_id":"","url":"https://api.github.com/users/arielnabavian","html_url":"https://github.com/arielnabavian","followers_url":"https://api.github.com/users/arielnabavian/followers","following_url":"https://api.github.com/users/arielnabavian/following{/other_user}","gists_url":"https://api.github.com/users/arielnabavian/gists{/gist_id}","starred_url":"https://api.github.com/users/arielnabavian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielnabavian/subscriptions","organizations_url":"https://api.github.com/users/arielnabavian/orgs","repos_url":"https://api.github.com/users/arielnabavian/repos","events_url":"https://api.github.com/users/arielnabavian/events{/privacy}","received_events_url":"https://api.github.com/users/arielnabavian/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-07-22T17:50:37Z","updated_at":"2026-07-22T17:50:37Z","body":"@strandly-the-agent review this","author_association":"NONE","reactions":{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5049534492/reactions","total_count":2,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":1,"eyes":1},"performed_via_github_app":null,"minimized":null},{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5051489037","html_url":"https://github.com/aws/bedrock-agentcore-sdk-python/pull/588#issuecomment-5051489037","issue_url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588","id":5051489037,"node_id":"IC_kwDOPIocp88AAAABLRebDQ","user":{"login":"arielnabavian","id":207775339,"node_id":"U_kgDODGJmaw","avatar_url":"https://avatars.githubusercontent.com/u/207775339?v=4","gravatar_id":"","url":"https://api.github.com/users/arielnabavian","html_url":"https://github.com/arielnabavian","followers_url":"https://api.github.com/users/arielnabavian/followers","following_url":"https://api.github.com/users/arielnabavian/following{/other_user}","gists_url":"https://api.github.com/users/arielnabavian/gists{/gist_id}","starred_url":"https://api.github.com/users/arielnabavian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielnabavian/subscriptions","organizations_url":"https://api.github.com/users/arielnabavian/orgs","repos_url":"https://api.github.com/users/arielnabavian/repos","events_url":"https://api.github.com/users/arielnabavian/events{/privacy}","received_events_url":"https://api.github.com/users/arielnabavian/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-07-22T20:59:38Z","updated_at":"2026-07-22T20:59:38Z","body":"@strandly-the-agent read all the comments on this pr. Read the comments thoroughly and makes sure we are filling the requirements of the given task, (port typescript AgentCoreMemoryStore to python AgentCoreMemoryStore). Make sure not to add any logic changes outside of whats required for 1-1 parity. Make sure the code comments are all address, make a revision to the PR once you are done. ","author_association":"NONE","reactions":{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5051489037/reactions","total_count":1,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":1},"performed_via_github_app":null,"minimized":null},{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5053213547","html_url":"https://github.com/aws/bedrock-agentcore-sdk-python/pull/588#issuecomment-5053213547","issue_url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588","id":5053213547,"node_id":"IC_kwDOPIocp88AAAABLTHraw","user":{"login":"strandly-the-agent","id":295955999,"node_id":"U_kgDOEaPuHw","avatar_url":"https://avatars.githubusercontent.com/u/295955999?v=4","gravatar_id":"","url":"https://api.github.com/users/strandly-the-agent","html_url":"https://github.com/strandly-the-agent","followers_url":"https://api.github.com/users/strandly-the-agent/followers","following_url":"https://api.github.com/users/strandly-the-agent/following{/other_user}","gists_url":"https://api.github.com/users/strandly-the-agent/gists{/gist_id}","starred_url":"https://api.github.com/users/strandly-the-agent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strandly-the-agent/subscriptions","organizations_url":"https://api.github.com/users/strandly-the-agent/orgs","repos_url":"https://api.github.com/users/strandly-the-agent/repos","events_url":"https://api.github.com/users/strandly-the-agent/events{/privacy}","received_events_url":"https://api.github.com/users/strandly-the-agent/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-07-23T01:06:01Z","updated_at":"2026-07-23T01:06:01Z","body":"Revision pushed at `bac5ffee`: all current maintainer comments are addressed while keeping the MemoryStore behavior aligned with the TypeScript source.\n\n- Contained the APIs under `strands.memorystore` / `strands.memorysessionmanager`; preserved existing SessionManager imports and patch paths.\n- Removed runtime version probing and ECMAScript-emulation helpers; retained the source retrieval/write semantics without adding pagination or service preflight.\n- Reused `MEMORY_PREPOPULATED_ID`, restored unrelated `TESTING.md` content, transferred relevant source rationale comments, and corrected the new docs/examples.\n- Verified: **2952 passed, 10 skipped, 4 xpassed**; Ruff and lock checks passed; 18 live tests collect; wheel build passed. Live AWS was not run.\n\n<details><summary>Review disposition</summary>\n\nThe two earlier Strandly implementation blockers requested behavior beyond the TypeScript source. Per the explicit 1:1-parity direction, this revision intentionally does not implement them. The two documentation findings are fixed. Full traceability and validation evidence are in the updated PR description.\n\n</details>","author_association":"CONTRIBUTOR","reactions":{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5053213547/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null,"minimized":null},{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5053431228","html_url":"https://github.com/aws/bedrock-agentcore-sdk-python/pull/588#issuecomment-5053431228","issue_url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588","id":5053431228,"node_id":"IC_kwDOPIocp88AAAABLTU9vA","user":{"login":"strandly-the-agent","id":295955999,"node_id":"U_kgDOEaPuHw","avatar_url":"https://avatars.githubusercontent.com/u/295955999?v=4","gravatar_id":"","url":"https://api.github.com/users/strandly-the-agent","html_url":"https://github.com/strandly-the-agent","followers_url":"https://api.github.com/users/strandly-the-agent/followers","following_url":"https://api.github.com/users/strandly-the-agent/following{/other_user}","gists_url":"https://api.github.com/users/strandly-the-agent/gists{/gist_id}","starred_url":"https://api.github.com/users/strandly-the-agent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strandly-the-agent/subscriptions","organizations_url":"https://api.github.com/users/strandly-the-agent/orgs","repos_url":"https://api.github.com/users/strandly-the-agent/repos","events_url":"https://api.github.com/users/strandly-the-agent/events{/privacy}","received_events_url":"https://api.github.com/users/strandly-the-agent/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-07-23T01:48:17Z","updated_at":"2026-07-23T01:48:17Z","body":"Final parity follow-up pushed at `56dcff8`.\n\nThe independent correctness pass found one Python-only overflow edge in over-fetch calculation: a huge finite factor overflowed to `inf`, where Python `math.ceil(inf)` raised instead of matching TypeScript's `Math.min(Math.ceil(...), 100)`. The calculation now clamps before integer conversion and has a regression test. This preserves source behavior; it does not add retrieval pagination or service preflight.\n\nCurrent focused validation: **386 passed**; Ruff, format, lock, and diff checks pass. The PR description now points to the final head and updated traceability evidence. Live AWS remains unrun.","author_association":"CONTRIBUTOR","reactions":{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5053431228/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null,"minimized":null},{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5063683731","html_url":"https://github.com/aws/bedrock-agentcore-sdk-python/pull/588#issuecomment-5063683731","issue_url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588","id":5063683731,"node_id":"IC_kwDOPIocp88AAAABLdGukw","user":{"login":"codecov-commenter","id":65553080,"node_id":"MDQ6VXNlcjY1NTUzMDgw","avatar_url":"https://avatars.githubusercontent.com/u/65553080?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-commenter","html_url":"https://github.com/codecov-commenter","followers_url":"https://api.github.com/users/codecov-commenter/followers","following_url":"https://api.github.com/users/codecov-commenter/following{/other_user}","gists_url":"https://api.github.com/users/codecov-commenter/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-commenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-commenter/subscriptions","organizations_url":"https://api.github.com/users/codecov-commenter/orgs","repos_url":"https://api.github.com/users/codecov-commenter/repos","events_url":"https://api.github.com/users/codecov-commenter/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-commenter/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-07-23T21:27:54Z","updated_at":"2026-08-05T21:26:52Z","body":"## [Codecov](https://app.codecov.io/gh/aws/bedrock-agentcore-sdk-python/pull/588?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) Report\n:x: Patch coverage is `95.75597%` with `16 lines` in your changes missing coverage. Please review.\n:warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`main@01d3800`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws#section-missing-base-commit) about missing BASE report.\n\n| [Files with missing lines](https://app.codecov.io/gh/aws/bedrock-agentcore-sdk-python/pull/588?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) | Patch % | Lines |\n|---|---|---|\n| [...e/memory/integrations/strands/memorystore/store.py](https://app.codecov.io/gh/aws/bedrock-agentcore-sdk-python/pull/588?src=pr&el=tree&filepath=src%2Fbedrock_agentcore%2Fmemory%2Fintegrations%2Fstrands%2Fmemorystore%2Fstore.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws#diff-c3JjL2JlZHJvY2tfYWdlbnRjb3JlL21lbW9yeS9pbnRlZ3JhdGlvbnMvc3RyYW5kcy9tZW1vcnlzdG9yZS9zdG9yZS5weQ==) | 86.79% | [7 Missing and 7 partials :warning: ](https://app.codecov.io/gh/aws/bedrock-agentcore-sdk-python/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) |\n| [...memory/integrations/strands/memorystore/factory.py](https://app.codecov.io/gh/aws/bedrock-agentcore-sdk-python/pull/588?src=pr&el=tree&filepath=src%2Fbedrock_agentcore%2Fmemory%2Fintegrations%2Fstrands%2Fmemorystore%2Ffactory.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws#diff-c3JjL2JlZHJvY2tfYWdlbnRjb3JlL21lbW9yeS9pbnRlZ3JhdGlvbnMvc3RyYW5kcy9tZW1vcnlzdG9yZS9mYWN0b3J5LnB5) | 97.91% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/aws/bedrock-agentcore-sdk-python/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) |\n| [.../memory/integrations/strands/memorystore/sender.py](https://app.codecov.io/gh/aws/bedrock-agentcore-sdk-python/pull/588?src=pr&el=tree&filepath=src%2Fbedrock_agentcore%2Fmemory%2Fintegrations%2Fstrands%2Fmemorystore%2Fsender.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws#diff-c3JjL2JlZHJvY2tfYWdlbnRjb3JlL21lbW9yeS9pbnRlZ3JhdGlvbnMvc3RyYW5kcy9tZW1vcnlzdG9yZS9zZW5kZXIucHk=) | 99.17% | [1 Missing :warning: ](https://app.codecov.io/gh/aws/bedrock-agentcore-sdk-python/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) |\n\n<details><summary>Additional details and impacted files</summary>\n\n\n\n```diff\n@@           Coverage Diff           @@\n##             main     #588   +/-   ##\n=======================================\n  Coverage        ?   88.65%           \n=======================================\n  Files           ?      118           \n  Lines           ?     9831           \n  Branches        ?     1487           \n=======================================\n  Hits            ?     8716           \n  Misses          ?      739           \n  Partials        ?      376           \n```\n\n| [Flag](https://app.codecov.io/gh/aws/bedrock-agentcore-sdk-python/pull/588/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) | Coverage Δ | |\n|---|---|---|\n| [unittests](https://app.codecov.io/gh/aws/bedrock-agentcore-sdk-python/pull/588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) | `88.65% <95.75%> (?)` | |\n\nFlags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws#carryforward-flags-in-the-pull-request-comment) to find out more.\n</details>\n\n[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/aws/bedrock-agentcore-sdk-python/pull/588?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws).   \n:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws).\n<details><summary> :rocket: New features to boost your workflow: </summary>\n\n- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.\n</details>","author_association":"NONE","reactions":{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5063683731/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null,"minimized":null},{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5092634047","html_url":"https://github.com/aws/bedrock-agentcore-sdk-python/pull/588#issuecomment-5092634047","issue_url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588","id":5092634047,"node_id":"IC_kwDOPIocp88AAAABL4ttvw","user":{"login":"arielnabavian","id":207775339,"node_id":"U_kgDODGJmaw","avatar_url":"https://avatars.githubusercontent.com/u/207775339?v=4","gravatar_id":"","url":"https://api.github.com/users/arielnabavian","html_url":"https://github.com/arielnabavian","followers_url":"https://api.github.com/users/arielnabavian/followers","following_url":"https://api.github.com/users/arielnabavian/following{/other_user}","gists_url":"https://api.github.com/users/arielnabavian/gists{/gist_id}","starred_url":"https://api.github.com/users/arielnabavian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielnabavian/subscriptions","organizations_url":"https://api.github.com/users/arielnabavian/orgs","repos_url":"https://api.github.com/users/arielnabavian/repos","events_url":"https://api.github.com/users/arielnabavian/events{/privacy}","received_events_url":"https://api.github.com/users/arielnabavian/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-07-27T14:30:57Z","updated_at":"2026-07-27T14:31:21Z","body":"For sanity, ran a manual audit as well [full_suite_interval_results.xlsx](https://github.com/user-attachments/files/30421197/full_suite_interval_results.xlsx)\r\n","author_association":"NONE","reactions":{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5092634047/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null,"minimized":null},{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5092929399","html_url":"https://github.com/aws/bedrock-agentcore-sdk-python/pull/588#issuecomment-5092929399","issue_url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588","id":5092929399,"node_id":"IC_kwDOPIocp88AAAABL4_vdw","user":{"login":"arielnabavian","id":207775339,"node_id":"U_kgDODGJmaw","avatar_url":"https://avatars.githubusercontent.com/u/207775339?v=4","gravatar_id":"","url":"https://api.github.com/users/arielnabavian","html_url":"https://github.com/arielnabavian","followers_url":"https://api.github.com/users/arielnabavian/followers","following_url":"https://api.github.com/users/arielnabavian/following{/other_user}","gists_url":"https://api.github.com/users/arielnabavian/gists{/gist_id}","starred_url":"https://api.github.com/users/arielnabavian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielnabavian/subscriptions","organizations_url":"https://api.github.com/users/arielnabavian/orgs","repos_url":"https://api.github.com/users/arielnabavian/repos","events_url":"https://api.github.com/users/arielnabavian/events{/privacy}","received_events_url":"https://api.github.com/users/arielnabavian/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-07-27T14:57:24Z","updated_at":"2026-07-27T14:57:24Z","body":"[full_suite_interval_report.docx](https://github.com/user-attachments/files/30422131/full_suite_interval_report.docx)\r\n","author_association":"NONE","reactions":{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5092929399/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null,"minimized":null},{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5135545674","html_url":"https://github.com/aws/bedrock-agentcore-sdk-python/pull/588#issuecomment-5135545674","issue_url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588","id":5135545674,"node_id":"IC_kwDOPIocp88AAAABMho1Sg","user":{"login":"arielnabavian","id":207775339,"node_id":"U_kgDODGJmaw","avatar_url":"https://avatars.githubusercontent.com/u/207775339?v=4","gravatar_id":"","url":"https://api.github.com/users/arielnabavian","html_url":"https://github.com/arielnabavian","followers_url":"https://api.github.com/users/arielnabavian/followers","following_url":"https://api.github.com/users/arielnabavian/following{/other_user}","gists_url":"https://api.github.com/users/arielnabavian/gists{/gist_id}","starred_url":"https://api.github.com/users/arielnabavian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielnabavian/subscriptions","organizations_url":"https://api.github.com/users/arielnabavian/orgs","repos_url":"https://api.github.com/users/arielnabavian/repos","events_url":"https://api.github.com/users/arielnabavian/events{/privacy}","received_events_url":"https://api.github.com/users/arielnabavian/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-07-30T19:47:19Z","updated_at":"2026-07-30T19:47:19Z","body":"@strandly-the-agent make a revision. \r\n\r\nMake sure we are not messing up any imports for existing clients. specifically these 1s\r\nRun actions/github-script@v8\r\nRequestError [HttpError]: Resource not accessible by integration\r\n    at /home/runner/work/_actions/actions/github-script/v8/dist/index.js:9537:21\r\n    at process.processTicksAndRejections (node:internal/process/task_queues:104:5)\r\n    at async eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v8/dist/index.js:36187:16), <anonymous>:27:3)\r\n    at async main (/home/runner/work/_actions/actions/github-script/v8/dist/index.js:36285:20) {\r\n  status: 403,\r\n  response: {\r\n    url: 'https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588/comments',\r\n    status: 403,\r\n    headers: {\r\n      'access-control-allow-origin': '*',\r\n      'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset, Warning',\r\n      'content-encoding': 'gzip',\r\n      'content-security-policy': \"default-src 'none'\",\r\n      'content-type': 'application/json; charset=utf-8',\r\n      date: 'Thu, 23 Jul 2026 21:25:52 GMT',\r\n      'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',\r\n      server: 'github.com',\r\n      'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',\r\n      'transfer-encoding': 'chunked',\r\n      vary: 'Accept-Encoding, Accept, X-Requested-With',\r\n      'x-accepted-github-permissions': 'issues=write; pull_requests=write',\r\n      'x-content-type-options': 'nosniff',\r\n      'x-frame-options': 'deny',\r\n      'x-github-api-version-selected': '2022-11-28',\r\n      'x-github-media-type': 'github.v3; format=json',\r\n      'x-github-request-id': '0440:130C5F:E9623B:ED2DED:6A6286E0',\r\n      'x-ratelimit-limit': '15000',\r\n      'x-ratelimit-remaining': '14992',\r\n      'x-ratelimit-reset': '1784843964',\r\n      'x-ratelimit-resource': 'core',\r\n      'x-ratelimit-used': '8',\r\n      'x-xss-protection': '0'\r\n    },\r\n    data: {\r\n      message: 'Resource not accessible by integration',\r\n      documentation_url: 'https://docs.github.com/rest/issues/comments#create-an-issue-comment',\r\n      status: '403'\r\n    }\r\n  },\r\n  request: {\r\n    method: 'POST',\r\n    url: 'https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588/comments',\r\n    headers: {\r\n      accept: 'application/vnd.github.v3+json',\r\n      'user-agent': 'actions/github-script octokit-core.js/5.0.1 Node.js/24',\r\n      authorization: 'bearer [REDACTED]',\r\n      'content-type': 'application/json; charset=utf-8'\r\n    },\r\n    body: '{\"body\":\"<!-- breaking-change-check -->\\\\n## ⚠️ Breaking Change Warning\\\\n\\\\nFound **3** potential breaking change(s) in this PR:\\\\n\\\\n\\\\u001b[1msrc/bedrock_agentcore/memory/integrations/strands/session_manager.py\\\\u001b[0m:0: logger: \\\\u001b[33mPublic object was removed\\\\u001b[39m\\\\n\\\\u001b[1msrc/bedrock_agentcore/memory/integrations/strands/bedrock_converter.py\\\\u001b[0m:0: logger: \\\\u001b[33mPublic object was removed\\\\u001b[39m\\\\n\\\\u001b[1msrc/bedrock_agentcore/memory/integrations/strands/converters/openai.py\\\\u001b[0m:0: logger: \\\\u001b[33mPublic object was removed\\\\u001b[39m\\\\n\\\\n---\\\\n> **Note:** This is an automated static analysis check. Some flagged changes may be intentional.\\\\n> Please confirm each item is expected and, if so, add a migration note to `CHANGELOG.md`.\"}',\r\n    request: {\r\n      agent: [Agent],\r\n      fetch: [Function: proxyFetch],\r\n      hook: [Function: bound bound register]\r\n    }\r\n  }\r\n}\r\nError: Unhandled error: HttpError: Resource not accessible by integration\r\n\r\n\r\nI also recommended moving our converters back under strands folder rather than memorysessionmanager folders since these are more reusable.\r\n\r\n\r\nAlso please investigate this bug we found in a bug bash:\r\n\r\n 1. max_search_results > 100 throws a raw service error — the clamp only runs on the min_score path\r\nCategory: recall · Severity: medium — plausible input, opaque failure, inconsistent with sibling path\r\n\r\nstore.py:208-213 computes top_k:\r\n\r\ntop_k = want\r\nif self._min_score is not None:\r\n    over_fetch = want * self._over_fetch_factor\r\n    top_k = MAX_TOPK if over_fetch >= MAX_TOPK else math.ceil(over_fetch)\r\nMAX_TOPK (100, the real service cap) is applied only inside the min_score branch. With no min_score, want goes to the wire verbatim. Construction validates max_search_results >= 1 but never <= 100.\r\n\r\nVerified against the live service:\r\n\r\nconfig\ttopK sent\tresult\r\nmax_search_results=100, no min_score\t100\tOK\r\nmax_search_results=101, no min_score\t101\tValidationException\r\nmax_search_results=200, no min_score\t200\tValidationException\r\nsearch(opts={\"max_search_results\": 200})\t200\tValidationException\r\nmax_search_results=200, min_score=0.1\t100\tOK — clamped\r\nValidationException: An error occurred (ValidationException) when calling the\r\nRetrieveMemoryRecords operation: 1 validation error detected: Value at\r\n'searchCriteria.topK' failed to satisfy constraint: Member must have value less\r\nthan or equal to 100\r\nAdding a min_score makes a previously-broken call start working, which is a confusing signal. Everything else in this port validates eagerly with an AgentCoreMemoryStore:-prefixed message; this one path defers to a raw botocore error.\r\n\r\nFix: hoist the clamp out of the if — top_k = min(top_k, MAX_TOPK) — or reject max_search_results > MAX_TOPK at construction and in search.\r\n\r\nRevise the CR.","author_association":"NONE","reactions":{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5135545674/reactions","total_count":2,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":1,"eyes":1},"performed_via_github_app":null,"minimized":null},{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5135875683","html_url":"https://github.com/aws/bedrock-agentcore-sdk-python/pull/588#issuecomment-5135875683","issue_url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588","id":5135875683,"node_id":"IC_kwDOPIocp88AAAABMh8-Yw","user":{"login":"strandly-the-agent","id":295955999,"node_id":"U_kgDOEaPuHw","avatar_url":"https://avatars.githubusercontent.com/u/295955999?v=4","gravatar_id":"","url":"https://api.github.com/users/strandly-the-agent","html_url":"https://github.com/strandly-the-agent","followers_url":"https://api.github.com/users/strandly-the-agent/followers","following_url":"https://api.github.com/users/strandly-the-agent/following{/other_user}","gists_url":"https://api.github.com/users/strandly-the-agent/gists{/gist_id}","starred_url":"https://api.github.com/users/strandly-the-agent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strandly-the-agent/subscriptions","organizations_url":"https://api.github.com/users/strandly-the-agent/orgs","repos_url":"https://api.github.com/users/strandly-the-agent/repos","events_url":"https://api.github.com/users/strandly-the-agent/events{/privacy}","received_events_url":"https://api.github.com/users/strandly-the-agent/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-07-30T20:22:05Z","updated_at":"2026-07-30T20:32:36Z","body":"Revision pushed at `8c06a2c`. All three items from your comment are handled.\n\n**1. Imports for existing clients.** The griffe step in *Detect Breaking Changes* exits 0 — the job died on its `actions/github-script` step (`403 Resource not accessible by integration`; `GITHUB_TOKEN` is read-only for fork PRs), so the report you pasted never made it onto the PR. It was right: 3 × `logger: Public object was removed`, caused by moving the SessionManager into `strands/memorysessionmanager/` behind re-export shims. That move also silently renamed the module loggers (`...strands.session_manager` → `...memorysessionmanager.session_manager`), which would break customer logging config keyed on those names. Reverted: `session_manager.py`, `config.py`, `bedrock_converter.py`, `converters/*` and the package root are byte-identical to `main`. griffe now reports **0 breaking changes**, and a runtime probe of every pre-existing module (`dir()`, `__all__`, `logger.name`, owning module per symbol) matches a `main` worktree exactly.\n\n**2. Converters back under `strands/`.** Done — `strands/converters/{__init__,openai,protocol}.py` are byte-identical to `main` again, so the reusable converters stay where they were and nothing under `memorysessionmanager/` exists in this PR.\n\n**3. Bug-bash defect: `max_search_results > 100`.** Fixed — `MAX_TOPK` is now applied on every retrieval path instead of only inside the `min_score` branch, and a one-time warning reports the reduced cap so it is not silent. Your matrix, reproduced offline at `8c06a2c`:\n\n| Config | `topK` before | `topK` now |\n|---|---|---|\n| `max_search_results=100`, no `min_score` | 100 | 100 |\n| `max_search_results=101`, no `min_score` | 101 → `ValidationException` | **100** |\n| `max_search_results=200`, no `min_score` | 200 → `ValidationException` | **100** |\n| `search(options={\"max_search_results\": 200})` | 200 → `ValidationException` | **100** |\n| `max_search_results=200`, `min_score=0.1` | 100 | 100 |\n\nThis is a **deliberate divergence from the TypeScript source** (which clamps only the over-fetch path) — flagged as such in the PR description so it does not read as a parity slip. I went with hoisting the clamp rather than rejecting `>100` eagerly, because rejecting would also break `max_search_results=200, min_score=0.1`, which works today; one line to flip if you prefer the hard error. The tests that asserted `topK == 101` are gone, replaced by 100/101/200 coverage with and without a score floor, the per-call `search_memory` option, and warn-once behaviour.\n\n<details><summary>Evidence & open items</summary>\n\n- At `8c06a2c`: **386 passed** focused, **3024 passed** full suite (the 2 remaining failures and the `deepeval` collection error reproduce unchanged on `main` with the same venv). `ruff`, `ruff format`, `mypy` on the new package, `griffe` (0), and `git diff --check` clean; 18 live tests collect (live AWS not run).\n- Branch also merges current `main` — it was `CONFLICTING`, now `MERGEABLE`; `pyproject`/`uv.lock` keep main's version and evals pins plus the `strands-agents>=1.46.0` floor.\n- Only pre-existing file still modified: two `TestAsyncMode` cases moved to the public `HookRegistry.get_callbacks_for` API — required by the 1.46 floor; they fail on `main` too under 1.46.\n- Pagination stays the fast follow you called on the `store.py` thread (a request for >100 records returns the first 100). The `CreateEvent` request-bound preflight is in the same bucket — happy to pull either into this PR.\n- `AgentCoreMemorySessionManager` containment is the one item I did not carry over, since it is what broke the import surface; ready to open it as a standalone PR.\n- `safety-gate` stays red by design: this PR still touches `.github/workflows/integration-testing.yml` to add the new live test to the memory matrix and install `pytest-asyncio`. Happy to drop that hunk if you would rather wire CI separately.\n\n</details>","author_association":"CONTRIBUTOR","reactions":{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5135875683/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null,"minimized":null},{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5172893951","html_url":"https://github.com/aws/bedrock-agentcore-sdk-python/pull/588#issuecomment-5172893951","issue_url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588","id":5172893951,"node_id":"IC_kwDOPIocp88AAAABNFQY_w","user":{"login":"arielnabavian","id":207775339,"node_id":"U_kgDODGJmaw","avatar_url":"https://avatars.githubusercontent.com/u/207775339?v=4","gravatar_id":"","url":"https://api.github.com/users/arielnabavian","html_url":"https://github.com/arielnabavian","followers_url":"https://api.github.com/users/arielnabavian/followers","following_url":"https://api.github.com/users/arielnabavian/following{/other_user}","gists_url":"https://api.github.com/users/arielnabavian/gists{/gist_id}","starred_url":"https://api.github.com/users/arielnabavian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielnabavian/subscriptions","organizations_url":"https://api.github.com/users/arielnabavian/orgs","repos_url":"https://api.github.com/users/arielnabavian/repos","events_url":"https://api.github.com/users/arielnabavian/events{/privacy}","received_events_url":"https://api.github.com/users/arielnabavian/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-08-03T23:40:40Z","updated_at":"2026-08-03T23:40:40Z","body":"@strandly-the-agent address these comments and revise the pr. ","author_association":"NONE","reactions":{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5172893951/reactions","total_count":2,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":1,"eyes":1},"performed_via_github_app":null,"minimized":null},{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5181653240","html_url":"https://github.com/aws/bedrock-agentcore-sdk-python/pull/588#issuecomment-5181653240","issue_url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588","id":5181653240,"node_id":"IC_kwDOPIocp88AAAABNNnA-A","user":{"login":"arielnabavian","id":207775339,"node_id":"U_kgDODGJmaw","avatar_url":"https://avatars.githubusercontent.com/u/207775339?v=4","gravatar_id":"","url":"https://api.github.com/users/arielnabavian","html_url":"https://github.com/arielnabavian","followers_url":"https://api.github.com/users/arielnabavian/followers","following_url":"https://api.github.com/users/arielnabavian/following{/other_user}","gists_url":"https://api.github.com/users/arielnabavian/gists{/gist_id}","starred_url":"https://api.github.com/users/arielnabavian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielnabavian/subscriptions","organizations_url":"https://api.github.com/users/arielnabavian/orgs","repos_url":"https://api.github.com/users/arielnabavian/repos","events_url":"https://api.github.com/users/arielnabavian/events{/privacy}","received_events_url":"https://api.github.com/users/arielnabavian/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-08-04T16:10:10Z","updated_at":"2026-08-04T16:10:10Z","body":"@strandly-the-agent address these comments from \r\njariy17 and revise the pr","author_association":"NONE","reactions":{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5181653240/reactions","total_count":2,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":1,"eyes":1},"performed_via_github_app":null,"minimized":null},{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5181928329","html_url":"https://github.com/aws/bedrock-agentcore-sdk-python/pull/588#issuecomment-5181928329","issue_url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588","id":5181928329,"node_id":"IC_kwDOPIocp88AAAABNN3ziQ","user":{"login":"strandly-the-agent","id":295955999,"node_id":"U_kgDOEaPuHw","avatar_url":"https://avatars.githubusercontent.com/u/295955999?v=4","gravatar_id":"","url":"https://api.github.com/users/strandly-the-agent","html_url":"https://github.com/strandly-the-agent","followers_url":"https://api.github.com/users/strandly-the-agent/followers","following_url":"https://api.github.com/users/strandly-the-agent/following{/other_user}","gists_url":"https://api.github.com/users/strandly-the-agent/gists{/gist_id}","starred_url":"https://api.github.com/users/strandly-the-agent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strandly-the-agent/subscriptions","organizations_url":"https://api.github.com/users/strandly-the-agent/orgs","repos_url":"https://api.github.com/users/strandly-the-agent/repos","events_url":"https://api.github.com/users/strandly-the-agent/events{/privacy}","received_events_url":"https://api.github.com/users/strandly-the-agent/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-08-04T16:36:20Z","updated_at":"2026-08-04T16:36:20Z","body":"Revised at `5c5c0b0`, and my earlier replies to `jariy17` are now actually visible — they had been left in an unsubmitted review, which is why this looked unanswered. Sorry for the round trip.\n\nAll four of `jariy17`'s points, with the code:\n\n1. **Format helpers** — all three were sender-exclusive (only call sites were in `sender.py`), so `_format.py` is deleted and they are private members of `AgentCoreEventSender`.\n2. **`MemoryClient`** — went further than \"you can pass one\": the default connection is now built through `MemoryClient(..., integration_source=\"strands\")` and the store calls the data-plane client it vends, so there's no second hand-rolled boto3 client. Its higher-level `create_event`/`retrieve_memories` still can't be used (no `clientToken`, and swallowed `ClientError`), which is what the two-method `Protocol` documents.\n3. **`_assert_writable_topology`** — renamed and dropped from the package `__all__`.\n4. **30-minute integration timeout** — hunk removed; this PR no longer touches any workflow, so `safety-gate` doesn't block the integration matrix.\n\nAlso rebased onto current `main`. The PR now touches no existing module, test, doc or workflow — only `pyproject.toml`/`uv.lock` plus the new `memorystore` package and its tests.\n\n<details><summary>Validation at <code>5c5c0b0</code></summary>\n\n`pytest tests/bedrock_agentcore/memory` → **774 passed** · focused Strands suite → **389 passed** · `tests/unit` → 344 · `tests/integration` → 28 passed, 1 skipped · config_bundle/evaluation/gateway/payments/services/tools → all passed · `ruff check` + `ruff format --check` clean · `mypy` on the new package clean · griffe **0 breaking changes** vs `main`.\n\nTwo caveats I won't paper over: the whole-`tests/` run doesn't finish in my sandbox — `runtime/test_a2a.py` fails twice and `identity` attempts a live `bedrock-agentcore` call — but both reproduce at the merged base with my changes stashed, so they're environmental; CI is the authority. Live AWS memory tests still need `MEMORY_PREPOPULATED_ID` and Bedrock access.\n\nAn independent review pass over the client-construction change is folded in (documented that `MemoryClient` re-checks the session by truthiness). The one tradeoff worth your call: `MemoryClient.__init__` also builds a control-plane client we never use — one construction per store set, no network. Happy to go back to a direct boto3 client if you'd rather not pay it.\n\n</details>","author_association":"CONTRIBUTOR","reactions":{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5181928329/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null,"minimized":null},{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5195626628","html_url":"https://github.com/aws/bedrock-agentcore-sdk-python/pull/588#issuecomment-5195626628","issue_url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588","id":5195626628,"node_id":"IC_kwDOPIocp88AAAABNa74hA","user":{"login":"arielnabavian","id":207775339,"node_id":"U_kgDODGJmaw","avatar_url":"https://avatars.githubusercontent.com/u/207775339?v=4","gravatar_id":"","url":"https://api.github.com/users/arielnabavian","html_url":"https://github.com/arielnabavian","followers_url":"https://api.github.com/users/arielnabavian/followers","following_url":"https://api.github.com/users/arielnabavian/following{/other_user}","gists_url":"https://api.github.com/users/arielnabavian/gists{/gist_id}","starred_url":"https://api.github.com/users/arielnabavian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielnabavian/subscriptions","organizations_url":"https://api.github.com/users/arielnabavian/orgs","repos_url":"https://api.github.com/users/arielnabavian/repos","events_url":"https://api.github.com/users/arielnabavian/events{/privacy}","received_events_url":"https://api.github.com/users/arielnabavian/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-08-05T18:21:28Z","updated_at":"2026-08-05T18:21:28Z","body":"@strandly-the-agent Make sure this breaking change is address    body: '{\"body\":\"<!-- breaking-change-check -->\\\\n## ⚠️ Breaking Change Warning\\\\n\\\\nFound **2** potential breaking change(s) in this PR:\\\\n\\\\n\\\\u001b[1msrc/bedrock_agentcore/runtime/a2a.py\\\\u001b[0m:0: A2A_CONTRACT_PORT: \\\\u001b[33mPublic object was removed\\\\u001b[39m\\\\n\\\\u001b[1msrc/bedrock_agentcore/runtime/a2a.py\\\\u001b[0m:0: A2A_PORT_ENV: \\\\u001b[33mPublic object was removed\\\\u001b[39m\\\\n\\\\n---\\\\n> **Note:** This is an automated static analysis check. Some flagged changes may be intentional.\\\\n> Please confirm each item is expected and, if so, add a migration note to `CHANGELOG.md`.\"}',\r\n\r\nWe don't want to break our customers imports.\r\n\r\nAdditionally get rid of this scoped down AgentCoreDataPlaneClient and AgentCoreClient. users should only be able to pass in the normal MemoryClient","author_association":"NONE","reactions":{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5195626628/reactions","total_count":2,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":1,"eyes":1},"performed_via_github_app":null,"minimized":null},{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5195983918","html_url":"https://github.com/aws/bedrock-agentcore-sdk-python/pull/588#issuecomment-5195983918","issue_url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/588","id":5195983918,"node_id":"IC_kwDOPIocp88AAAABNbRsLg","user":{"login":"strandly-the-agent","id":295955999,"node_id":"U_kgDOEaPuHw","avatar_url":"https://avatars.githubusercontent.com/u/295955999?v=4","gravatar_id":"","url":"https://api.github.com/users/strandly-the-agent","html_url":"https://github.com/strandly-the-agent","followers_url":"https://api.github.com/users/strandly-the-agent/followers","following_url":"https://api.github.com/users/strandly-the-agent/following{/other_user}","gists_url":"https://api.github.com/users/strandly-the-agent/gists{/gist_id}","starred_url":"https://api.github.com/users/strandly-the-agent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strandly-the-agent/subscriptions","organizations_url":"https://api.github.com/users/strandly-the-agent/orgs","repos_url":"https://api.github.com/users/strandly-the-agent/repos","events_url":"https://api.github.com/users/strandly-the-agent/events{/privacy}","received_events_url":"https://api.github.com/users/strandly-the-agent/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-08-05T18:51:48Z","updated_at":"2026-08-05T18:51:48Z","body":"Revised at `3de6915`. Both points handled.\n\n**1. The breaking-change report is a stale-branch artifact, not a removal.** `A2A_CONTRACT_PORT` and `A2A_PORT_ENV` were *added on `main`* by #615 (`207adb7`), after this branch's merge-base. griffe diffs `main` → PR tree, so it saw them missing from the older tree and reported \"Public object was removed\". This PR has never touched `src/bedrock_agentcore/runtime/a2a.py` — no customer import is affected. Merged current `main`; griffe now reports **0 breaking changes**, and the pre-existing Strands modules are still byte-identical to `main` (import paths, patch targets, logger names untouched).\n\n**2. `AgentCoreDataPlaneClient` and `AgentCoreClient` are gone.** The public contract is now just `MemoryClient`:\n\n```python\n# default — the integration builds MemoryClient(integration_source=\"strands\") itself\nstore = AgentCoreMemoryStore(memory_id=..., actor_id=..., session_id=..., namespace=\"/facts/{actorId}\")\n\n# or reuse your own connection\nstore = AgentCoreMemoryStore(..., client=MemoryClient(region_name=\"us-west-2\"))\n```\n\n`create_agentcore_memory_stores` and `AgentCoreEventSender` take the same thing, and `create_agentcore_memory_stores` shares one client across the topology. `resolve_data_plane_client()` is deleted too; each entry point simply uses the `bedrock-agentcore` data plane the client vends — needed because `MemoryClient.create_event` can't carry the `clientToken` the sender uses for idempotent retries, and `MemoryClient.retrieve_memories` swallows `ClientError` that `MemoryManager` expects to surface.\n\n<details><summary>Validation at <code>3de6915</code></summary>\n\n`pytest tests/bedrock_agentcore/memory` → **774 passed** · memorystore package → 163 · `tests/unit`+`tests/integration` → 372 passed, 1 skipped · runtime/evaluation/gateway/services/tools/config_bundle → 1134 passed, 4 xpassed, 2 failed\\* · `ruff` + `ruff format` clean · `mypy` on the new package clean · griffe **0** · 18 live tests collect.\n\n\\* Those two are `runtime/test_a2a.py::TestBuildA2AApp::test_auto_builds_card_when_none_provided` and `::TestServeA2A::test_explicit_port_overrides_environment`; they reproduce identically at the merged base with my commit stashed, so they're environmental in my sandbox (a2a-sdk version), not this branch. `tests/bedrock_agentcore/identity` also attempts a live AWS call here and hangs. CI is the authority for both.\n\nAn independent review pass ran over the client-contract commit; its one finding (a mypy fixture block that became a duplicate once the Protocol was gone) is folded in. Test doubles now wrap a data-plane mock in `Mock(spec=MemoryClient)`, and the live suite swaps the vended `gmdp_client` on a copied `MemoryClient` to count/capture calls.\n\nOne mechanical note: my sandbox token can't push `.github/workflows/**`, so the workflow file `main` updated came in through the API as `3de6915`. The PR still shows no workflow diff.\n\n</details>","author_association":"CONTRIBUTOR","reactions":{"url":"https://api.github.com/repos/aws/bedrock-agentcore-sdk-python/issues/comments/5195983918/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null,"minimized":null}]